Compatibility check + loldrivers API #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 21, 2024 19:27
… empty). switched to use the JSON api (which also had more information)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lol_vulnerable_driver_parserdidn't seem to work as intended. The matching todriver.endswith('.sys')did not seem to ever work correctly (always returned nothing) so I modified the code to use the loldrivers API instead (which also provides a lot more info than the web scrape).Also added a check that the machine is a windows device and early exit in the case of incompatibility, seeing as it continued to attempt to work on my non-windows machine.
I don't have a Windows VM spun up currently to test so feel free to mess around with it before merging if you and something that doesn't work