Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android native theme sync #6029

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Rohit3523
Copy link
Contributor

@Rohit3523 Rohit3523 commented Nov 29, 2024

Proposed changes

This PR addresses an issue where Android native components display themes based on the operating system's settings, which may differ from the app's chosen theme. The implementation introduces a native module that synchronizes the app's theme with system settings, ensuring consistent visual rendering across all app components.
Additionally, this pull request modifies the modal text and background color to align with the active app theme.

Issue(s)

N/A

How to test or reproduce

  1. Set Android system theme to light mode
  2. Open app and set app theme to dark mode
  3. Try to delete any message
  4. Notice the delete alert shows in light theme

Screenshots

Scenario Android Theme App Theme Before After
Scenario 1 Dark Light Before Video After Video
Scenario 2 Light Dark Before Video After Video

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@Rohit3523 Rohit3523 marked this pull request as draft January 8, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant