Map component #110
Open
Map component #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pijaro
force-pushed
the
pjaroszek/map_component
branch
from
7f05a2b to
8a6bf1a
Compare
Signed-off-by: Piotr Jaroszek <[email protected]>
Signed-off-by: Piotr Jaroszek <[email protected]>
Signed-off-by: Piotr Jaroszek <[email protected]>
Signed-off-by: Piotr Jaroszek <[email protected]>
Signed-off-by: Piotr Jaroszek <[email protected]>
Signed-off-by: Piotr Jaroszek <[email protected]>
Signed-off-by: Piotr Jaroszek <[email protected]>
pijaro
force-pushed
the
pjaroszek/map_component
branch
from
a55442d to
86010bb
Compare
Signed-off-by: Piotr Jaroszek <[email protected]>
|
Fixes o3de/o3de-extras#157 |
pawellech1
reviewed
Aug 19, 2022
| //! Convert Transform from the map coordinate system. | ||
| //! @param transform - Transform to be converted. | ||
| //! @return Copy of a Transform in the world coordinate system. | ||
| virtual AZ::Transform ConvertFromMapCoordinateSystem(AZ::Transform transform) = 0; |
There was a problem hiding this comment.
here and above, if transforms will not be changed in the overriding functions it will be better to use const AZ::Transform & as arguments
| //! Updates the hook Transform | ||
| void SetHook(); | ||
|
|
||
| bool m_useMapHook = false; |
There was a problem hiding this comment.
I think members of this class should be made private.
| //! Configuration for handling geodetic map info. | ||
| //! This configuration allows setting a geographic coordinate system hook to a simulation scene. | ||
| //! System hook points to the real-world location in latitude, longitude, and altitude offsets. | ||
| class GeodeticConfiguration |
There was a problem hiding this comment.
I don't see any constructor defined for this class. Is it omitted on purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map component: