Architectural changes to support multi-return feature #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebraszka
reviewed
May 15, 2024
nebraszka
reviewed
May 15, 2024
src/gpu/nodeKernels.cu
Outdated
Comment on lines
248
to
257
| if (first.isHit[beamIdx]) { | ||
| first.xyz[beamIdx] = beamSamples.xyz[beamIdx * samplesPerBeam + firstIdx]; | ||
| first.distance[beamIdx] = beamSamples.distance[beamIdx * samplesPerBeam + firstIdx]; | ||
| } | ||
|
|
||
| last.isHit[beamIdx] = lastIdx >= 0; | ||
| if (last.isHit[beamIdx]) { | ||
| last.xyz[beamIdx] = beamSamples.xyz[beamIdx * samplesPerBeam + lastIdx]; | ||
| last.distance[beamIdx] = beamSamples.distance[beamIdx * samplesPerBeam + lastIdx]; | ||
| } |
There was a problem hiding this comment.
Is it not like if beamSamples.isHit[beamIdx * samplesPerBeam + sampleIdx] != 0 (line 235 above) then you will always have first and last? If this is true, then two if-statements here may technically be reduced to one.
src/graph/NodesCore.hpp
Outdated
|
|
||
| void enqueueExecImpl() override {} | ||
|
|
||
| // Point cloud description |
There was a problem hiding this comment.
Probably unsed docs from copy/paste?
prybicki
force-pushed
the
feature/arch-changes-mr
branch
from
964fcf2 to
b5be808
Compare
msz-rai
pushed a commit
that referenced
this pull request
Jul 13, 2024
* Architectural changes to support multi-return feature
msz-rai
pushed a commit
that referenced
this pull request
Jul 15, 2024
* Architectural changes to support multi-return feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.