Merge pull request #1773 from RoboSats/fix-desktop-release-artifacts

Fix Desktop release artifacts
RoboSats · Feb 22, 2025 · 951a71d · 951a71d
2 parents 9da8588 + 272fe7b
commit 951a71d
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 21 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -94,6 +94,7 @@ jobs:
         with:
           body_path: release_notes.md
           generate_release_notes: true
+          draft: true
 
       # Upload app-universal-release APK artifact asset
       - name: 'Download universal APK Artifact'
@@ -166,8 +167,8 @@ jobs:
       - name: 'Download macOS Build Artifact'
         uses: actions/download-artifact@v4
         with:
-          name: robosats-desktop-${{ needs.check-versions.outputs.semver }}-mac-darwin-x64.zip
-          path: .
+          path: desktopApp/release-builds/Robosats-darwin-x64
+          name: robosats-desktop-${{ inputs.semver }}-mac-darwin-x64.zip
 
       - name: 'Upload macOS Build Artifact'
         id: upload-release-mac-zip-asset
@@ -176,15 +177,15 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           upload_url: ${{ steps.create-release.outputs.upload_url }}
-          asset_path: robosats-desktop-${{ needs.check-versions.outputs.semver }}-mac-darwin-x64.zip
-          asset_name: robosats-desktop-${{ needs.check-versions.outputs.semver }}-mac-darwin-x64.zip
+          asset_path: desktopApp/release-builds/Robosats-darwin-x64
+          asset_name: robosats-desktop-${{ inputs.semver }}-mac-darwin-x64.zip
           asset_content_type: application/zip
 
       - name: 'Download linux Build Artifact'
         uses: actions/download-artifact@v4
         with:
-          name: robosats-desktop-${{ needs.check-versions.outputs.semver }}-linux-x64.zip
-          path: .
+          path: desktopApp/release-builds/Robosats-linux-x64
+          name: robosats-desktop-${{ inputs.semver }}-linux-x64.zip
 
       - name: 'Upload linux Build Artifact'
         id: upload-release-linux-zip-asset
@@ -193,15 +194,15 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           upload_url: ${{ steps.create-release.outputs.upload_url }}
-          asset_path: robosats-desktop-${{ needs.check-versions.outputs.semver }}-linux-x64.zip
-          asset_name: robosats-desktop-${{ needs.check-versions.outputs.semver }}-linux-x64.zip
+          asset_path: desktopApp/release-builds/Robosats-linux-x64
+          asset_name: robosats-desktop-${{ inputs.semver }}-linux-x64.zip
           asset_content_type: application/zip
 
       - name: 'Download Windows Build Artifact'
         uses: actions/download-artifact@v4
         with:
-          name: robosats-desktop-${{ needs.check-versions.outputs.semver }}-win32-ia32.zip
-          path: .
+          path: desktopApp/release-builds/Robosats-win32-ia32
+          name: robosats-desktop-${{ inputs.semver }}-win32-ia32.zip
 
       - name: 'Upload Windows Build Artifact'
         id: upload-release-win-zip-asset
@@ -210,6 +211,6 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           upload_url: ${{ steps.create-release.outputs.upload_url }}
-          asset_path: robosats-desktop-${{ needs.check-versions.outputs.semver }}-win32-ia32.zip
-          asset_name: robosats-desktop-${{ needs.check-versions.outputs.semver }}-win32-ia32.zip
+          asset_path: desktopApp/release-builds/Robosats-win32-ia32
+          asset_name: robosats-desktop-${{ inputs.semver }}-win32-ia32.zip
           asset_content_type: application/zip
diff --git a/release_notes.md b/release_notes.md
@@ -2,11 +2,14 @@ RoboSats v0.7.4 is now out! :rocket:
 
 # Changes
 ## What's new
-- Websockets now working on Android app: this enables instant chat and Nostr order book features! @koalasat
-- First external coordinator now available: you can now see @lnp2pbot orders on RoboSats UI @koalasat
-- Better display coordinator info on the Create Order form @koalasat
-- Charts now depend on selected currency @femelo
-- Fixed exchange summary aggregatons @koalasat
+### For Users
+- You can now see @lnp2pbot orders on RoboSats mobile app @koalasat
+- Changed URLs to https://robosats.org and new onion @koalasat
+- Order creation view now displays all available payment methods @koalasat
+- Test fixes @jerryfletcher21
+- Libraries updates @KoalaSat
+### For Coordinators
+- Libraries updates @koalasat
 
 # Android
 
@@ -22,7 +25,7 @@ Smaller bundles for each CPU architecture available in the attachments.
 
 3. Verify the signer is actually ~~Reckless-Satoshi (fingerprints match): [B4AB5F19113D4125DDF217739C4585B561315571](https://keys.openpgp.org/vks/v1/by-fingerprint/B4AB5F19113D4125DDF217739C4585B561315571)~~ KoalaSat [8FCDBF574CCFD73DB68B00CC2F7F61C6146AB157](https://keys.openpgp.org/vks/v1/by-fingerprint/8FCDBF574CCFD73DB68B00CC2F7F61C6146AB157)
 
-Alternatively you can also verify with the release with the SHA256 checksum.
+Additionally, you can download it from [Izzysoft repository](https://apt.izzysoft.de/fdroid/) or [ZapStore](https://zapstore.dev/)
 
 # Desktop
 
@@ -33,10 +36,18 @@ Find the zip file that suits with your operative system:
 - [Mac](https://github.com/RoboSats/robosats/releases/download/v0.7.4-alpha/robosats-desktop-v0.7.4.alpha-mac-darwin-x64.zip)
 - [Linux](https://github.com/RoboSats/robosats/releases/download/v0.7.4-alpha/robosats-desktop-v0.7.4.alpha-linux-x64.zip)
 
-
 ### Verify the app using GPG:
 
-You can also verify with the release with the SHA256 checksum.
+1. Download the ascii armored signature:
+
+- [Windows](https://github.com/RoboSats/robosats/releases/download/v0.7.4-alpha/robosats-desktop-v0.7.4.alpha-win32-ia32.zip.asc)
+- [Mac](https://github.com/RoboSats/robosats/releases/download/v0.7.4-alpha/robosats-desktop-v0.7.4.alpha-mac-darwin-x64.zip.asc)
+- [Linux](https://github.com/RoboSats/robosats/releases/download/v0.7.4-alpha/robosats-desktop-v0.7.4.alpha-linux-x64.zip.asc)
+
+3. Run this command on a directory that contains the apk file and and the ascii armored signature.
+`gpg --verify robosats-v0.7.4.alpha-....asc`
+
+4. Verify the signer is actually ~~Reckless-Satoshi (fingerprints match): [B4AB5F19113D4125DDF217739C4585B561315571](https://keys.openpgp.org/vks/v1/by-fingerprint/B4AB5F19113D4125DDF217739C4585B561315571)~~ KoalaSat [8FCDBF574CCFD73DB68B00CC2F7F61C6146AB157](https://keys.openpgp.org/vks/v1/by-fingerprint/8FCDBF574CCFD73DB68B00CC2F7F61C6146AB157)
 
 # Docker Images
 
@@ -54,4 +65,3 @@ docker pull recksato/robosats-client:v0.7.4-alpha
 ```
 
 See [nodeapp/docker-compose.yml](https://github.com/Reckless-Satoshi/robosats/blob/2cd9d748706a8dcc0f03006b483acc6000e0572a/nodeapp/docker-compose.yml) for an example docker-compose usage of the `robosats-client` image.
-