Better tests

RoboSats · Feb 25, 2025 · 40a8945 · 40a8945
1 parent 3399be9
commit 40a8945
Showing 1 changed file with 17 additions and 5 deletions.
diff --git a/tests/test_trade_pipeline.py b/tests/test_trade_pipeline.py
@@ -903,18 +903,23 @@ def test_cancel_public_order_by_taker(self):
         """
         trade = Trade(self.client)
         trade.publish_order()
-        trade.take_order()
 
+        trade.take_order()
+        data = trade.response.json()
         self.assertEqual(trade.response.status_code, 200)
+        self.assertResponse(trade.response)
+        self.assertTrue(data["is_pretaker"])
+        self.assertFalse(data["is_taker"])
 
         trade.cancel_order(trade.taker_index)
-
         data = trade.response.json()
         self.assertEqual(data["bad_request"], "You are not a participant in this order")
 
-        trade.get_order()
-
+        trade.get_order(trade.maker_index)
+        data = trade.response.json()
         self.assertEqual(trade.response.status_code, 200)
+        self.assertResponse(trade.response)
+        self.assertTrue(data["is_maker"])
 
     def test_cancel_public_order_by_third(self):
         """
@@ -924,11 +929,16 @@ def test_cancel_public_order_by_third(self):
         trade.publish_order()
         trade.take_order()
 
+        data = trade.response.json()
         self.assertEqual(trade.response.status_code, 200)
+        self.assertResponse(trade.response)
+        self.assertTrue(data["is_pretaker"])
 
         trade.take_order_third()
-
+        data = trade.response.json()
         self.assertEqual(trade.response.status_code, 200)
+        self.assertResponse(trade.response)
+        self.assertTrue(data["is_pretaker"])
 
         trade.cancel_order(trade.third_index)
 
@@ -938,11 +948,13 @@ def test_cancel_public_order_by_third(self):
         trade.get_order(trade.maker_index)
         data = trade.response.json()
         self.assertEqual(trade.response.status_code, 200)
+        self.assertResponse(trade.response)
         self.assertTrue(data["is_maker"])
 
         trade.get_order(trade.taker_index)
         data = trade.response.json()
         self.assertEqual(trade.response.status_code, 200)
+        self.assertResponse(trade.response)
         self.assertFalse(data["is_participant"])
         self.assertTrue(data["is_pretaker"])
         self.assertFalse(data["is_taker"])