Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annual Tradition of Deleting Stuff We Haven't Used In Years #2311

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

sid-parikh
Copy link
Contributor

Description

I deleted:

  • rj_gameplay
  • a number of python-related files
  • i may have gone too hard with the python-related files
  • we will see
  • modeling/
  • Dockerfile.comp (and renamed our CI dockerfile)

Associated / Resolved Issue

my mental well-being

Steps to Test

Everything Still Works

  1. make clean && make perf && make run-sim
  2. docs still build: https://rj-rc-software.readthedocs.io/en/sp-delete-more-stuff/
  3. hopefully CI still works (TBD)
  4. i guess i can test run-real at the shop

@sid-parikh sid-parikh force-pushed the sp/delete-more-stuff branch 3 times, most recently from a626931 to e077497 Compare November 6, 2024 16:32
Signed-off-by: Sid Parikh <[email protected]>
Signed-off-by: Sid Parikh <[email protected]>
Signed-off-by: Sid Parikh <[email protected]>
@sid-parikh
Copy link
Contributor Author

deleting rj_gameplay is potentially controversial. feel free to debate me

Copy link
Contributor

@jacksherling jacksherling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. We shouldn't leave stagnant code/configs/docs in the current codebase.

Copy link
Contributor

@sanatd33 sanatd33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good idea, we can always view the python files on github if we need them as a reference

Copy link
Contributor

@rishiso rishiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally the readme got updated 🥹

@sid-parikh sid-parikh merged commit fd60934 into ros2 Jan 23, 2025
2 checks passed
@sid-parikh sid-parikh deleted the sp/delete-more-stuff branch January 23, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants