Update Phan ignores

RoboJackets · Feb 12, 2025 · dc718ee · dc718ee
1 parent 4a45518
commit dc718ee
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 6 deletions.
diff --git a/.phan/config.php b/.phan/config.php
@@ -52,9 +52,11 @@
         'PhanTypeInvalidCallableArrayKey',
         'PhanTypeInvalidCallableArraySize',
         'PhanTypeMismatchArgument',
+        'PhanTypeMismatchArgumentInternal',
         'PhanTypeMismatchArgumentProbablyReal',
         'PhanTypeMismatchArgumentSuperType',
         'PhanTypeMismatchReturn',
+        'PhanTypeSuspiciousStringExpression',
         'PhanUndeclaredFunctionInCallable',
         'PhanUndeclaredMethod',
         'PhanUnreferencedClosure',

diff --git a/app/Jobs/CreateOrUpdateUserFromBuzzAPI.php b/app/Jobs/CreateOrUpdateUserFromBuzzAPI.php
@@ -65,7 +65,7 @@ public function __construct(
     /**
      * Execute the job.
      *
-     * @phan-suppress PhanTypeExpectedObjectPropAccessButGotNull,PhanTypeMismatchArgumentInternal
+     * @phan-suppress PhanTypeExpectedObjectPropAccessButGotNull
      */
     public function handle(): void
     {

diff --git a/app/Nova/Actions/Payments/RecordCheckPayment.php b/app/Nova/Actions/Payments/RecordCheckPayment.php
@@ -104,8 +104,6 @@ static function (string $attribute, string $value, callable $fail) use ($payable
 
     /**
      * The note to add to the payment.
-     *
-     * @phan-suppress PhanTypeSuspiciousStringExpression
      */
     protected static function note(ActionFields $fields): string
     {

diff --git a/app/Nova/Actions/Payments/RecordPayment.php b/app/Nova/Actions/Payments/RecordPayment.php
@@ -37,7 +37,6 @@ abstract class RecordPayment extends Action
      * @param  \Illuminate\Support\Collection<int,\App\Models\Payable>  $models
      *
      * @phan-suppress PhanUndeclaredConstantOfClass
-     * @phan-suppress PhanTypeSuspiciousStringExpression
      * @phan-suppress PhanTypeMismatchProperty
      */
     public function handle(ActionFields $fields, Collection $models)

diff --git a/app/Nova/Actions/Payments/RefundOfflinePayment.php b/app/Nova/Actions/Payments/RefundOfflinePayment.php
@@ -64,7 +64,6 @@ class RefundOfflinePayment extends Action
      * @param  \Illuminate\Support\Collection<int,\App\Models\Payment>  $models
      *
      * @phan-suppress PhanTypeMismatchPropertyProbablyReal
-     * @phan-suppress PhanTypeSuspiciousStringExpression
      */
     public function handle(ActionFields $fields, Collection $models)
     {

diff --git a/app/Nova/Actions/Payments/RefundSquarePayment.php b/app/Nova/Actions/Payments/RefundSquarePayment.php
@@ -65,7 +65,6 @@ class RefundSquarePayment extends Action
      * @param  \Illuminate\Support\Collection<int,\App\Models\Payment>  $models
      *
      * @phan-suppress PhanTypeMismatchPropertyProbablyReal
-     * @phan-suppress PhanTypeSuspiciousStringExpression
      * @phan-suppress PhanPossiblyFalseTypeArgument
      */
     public function handle(ActionFields $fields, Collection $models)

diff --git a/app/Traits/GetMorphClassStatic.php b/app/Traits/GetMorphClassStatic.php
@@ -11,6 +11,13 @@
  */
 trait GetMorphClassStatic
 {
+    /**
+     * Get the morph class string for this class.
+     *
+     * @return string
+     *
+     * @phan-suppress PhanPossiblyFalseTypeReturn
+     */
     public static function getMorphClassStatic(): string
     {
         return array_search(static::class, Relation::morphMap(), true);
-Original file line number
+Diff line change
@@ Expand Up @@
         /**
          * The note to add to the payment.
-         *
-         * @phan-suppress PhanTypeSuspiciousStringExpression
          */
         protected static function note(ActionFields $fields): string
         {
@@ Expand Down @@