Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android TLC: 2023 edition (with 2024 goodies) #65

Merged
merged 34 commits into from
Jul 18, 2024
Merged

Android TLC: 2023 edition (with 2024 goodies) #65

merged 34 commits into from
Jul 18, 2024

Conversation

evan10s
Copy link
Member

@evan10s evan10s commented Aug 20, 2023 •
edited
Loading

  • Target SDK v35 so Google doesn't yell at us
  • Update to Material 3
  • Update to newer dependency / Kotlin compiler versions where possible
    • Because of this change, we now compile to Java 17 as well
  • Migrate to ksp from kapt

To do:

  • Fix navbar color in light mode to not be white
  • Update CI docker image to include Java 17
  • Double-check screens for UI bugs - light + dark mode
    • Auth
    • Attendance
    • Settings
    • Permissions error
    • Server error
  • Remove/resolve any remaining M3 upgrade TODOs
    • Callout dark mode
    • NfcRequired crash
  • Update in-app update prompts to latest method

@evan10s evan10s linked an issue Aug 20, 2023 that may be closed by this pull request
Target Android API level 33 #63
Closed
@robojackets-concourse

This comment was marked as outdated.

Sign in to view
evan10s added 3 commits June 19, 2024 17:19
@evan10s
Merge branch 'refs/heads/main' into evan/m3
38e3cf8 
# Conflicts:
#	build.gradle.kts
#	ci/dockerfiles/Dockerfile
#	gradle/wrapper/gradle-wrapper.properties
@evan10s
Use Java 17
eb537cd
@evan10s
Update dependencies and finish M3 upgrade
59b9e96
@evan10s evan10s changed the title Android TLC: 2023 Edition Android TLC: 2023 edition (with 2024 goodies) Jun 20, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@evan10s evan10s requested a review from kberzinch July 14, 2024 18:57
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
kberzinch
kberzinch previously approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@kberzinch kberzinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

README.md Outdated Show resolved Hide resolved
app/src/main/java/org/robojackets/apiary/MainActivity.kt Show resolved Hide resolved
app/src/main/java/org/robojackets/apiary/ui/update/UpdateGate.kt Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

Download PR build v1.2.1-PullRequest0065.85

PR builds are unsigned and always use version code 1. Follow these steps to enable installing them on your device.

@evan10s
Copy link
Member Author

evan10s commented Jul 18, 2024

Kristaps is on vacation and had approved, and latest internal app sharing build above works for me, so merging anyways

@evan10s evan10s merged commit 2060ef7 into main Jul 18, 2024
3 checks passed
@evan10s evan10s deleted the evan/m3 branch July 18, 2024 03:25
@kberzinch kberzinch mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kberzinch kberzinch kberzinch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Target Android API level 33
2 participants
@evan10s @kberzinch