Skip to content

Commit

Permalink
Merge pull request #1 from RobertoMachorro/departureFromOriginal
Browse files Browse the repository at this point in the history
Resolve Framework usage Issues in a Project
  • Loading branch information
RobertoMachorro authored Jul 21, 2019
2 parents ff183da + 4062d15 commit 0214825
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 6 deletions.
14 changes: 9 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,17 @@ Check the tests for call examples, most are very atomic.

## Project Status

Currently, the code is in Framework form based of pristine code (no changes), it builds for macOS and passes all but 2 tests. The original source passes all tests under iOS.
Currently, the project is ready to use and defaults to macOS builds.

## Roadmap
## Pending

* Fix issues so that all tests pass.
* Fix [structure initializers, all are private by Swift default](https://stackoverflow.com/questions/51364620/getting-initializer-is-inaccessible-due-to-internal-protection-level).
* Add full support for [SecCopyErrorMessageString](https://developer.apple.com/documentation/security/1542001-security_framework_result_codes).
* iOS Target
* macOS and passes all but 2 tests. The original source passes all tests under iOS.

## Changes from Original Source

* Independent project and framework with shared schema for Carthage
* Public Queryable structs initializers

## Contributing

Expand Down
11 changes: 10 additions & 1 deletion SecureStore/SecureStoreQueryable.swift
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public struct GenericPasswordQueryable {
let service: String
let accessGroup: String?

init(service: String, accessGroup: String? = nil) {
public init(service: String, accessGroup: String? = nil) {
self.service = service
self.accessGroup = accessGroup
}
Expand Down Expand Up @@ -64,6 +64,15 @@ public struct InternetPasswordQueryable {
let securityDomain: String
let internetProtocol: InternetProtocol
let internetAuthenticationType: InternetAuthenticationType

public init(server: String, port: Int, path: String, securityDomain: String, internetProtocol: InternetProtocol, internetAuthenticationType: InternetAuthenticationType) {
self.server = server
self.port = port
self.path = path
self.securityDomain = securityDomain
self.internetProtocol = internetProtocol
self.internetAuthenticationType = internetAuthenticationType
}
}

extension InternetPasswordQueryable: SecureStoreQueryable {
Expand Down

0 comments on commit 0214825

Please sign in to comment.