Implement Default on interners for all backends #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s useful to have `Default` implemented for `StringInterner` for all backends, not just `DefaultBackend`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s useful to have
Defaultimplemented forStringInternerfor all backends, not justDefaultBackend, so that structs containing such interners canderive(Default)rather than having to implement it by hand. However, as can be seen in the changes to the doctests, this is not actually backwards compatible, becauseStringInterner::default()now requires types to be provided, so you may or may not consider it worth a semver break; feel free to just close this if you don’t want to do that, I don’t mind.