Added net performance graphs to MPClientList UI #3056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a spinoff from RigsOfRods#3055 Requires updated rorserver. New features: - Added send timestamp to `RoRnet::Header` - all packets now track their time shift between remote client and local client. Note that the existing truck time shift tracking made by Ulteq is unchanged for now. - Added queue timestamp to `RoRnet::Header` - all packets now track the delay between creating the packet and transmitting it to server. - Added recv queue timestamp to `NetRecvPacket` - all packets now track local delay between receiving packet and processing it. - Added 3 new graphs to the MPClientList UI: 1. timeshift (should be stable), 2. local recv lag, 3. remote send lag. Motivation: - to smoothen out character movement the same way truck movement is smoothed. That requires tracking the timeshift, and Ulteq's truck smoothing code is very much tied to `Actor` and `ActorManager`. - To clean up network timers - there are 3 separate timers (`Character`, `Actor`, `ActorManager` - the pattern is not clear). - To better understand and tweak network traffic. - I like diagnostic views. Time spent: 6.5hours, not counting rorserver.
ohlidalp
added a commit
to ohlidalp/ror-server
that referenced
this pull request
Jun 16, 2023
See RigsOfRods/rigs-of-rods#3056 - `RoRnet::Header` was updated with extra timestamps to track network performance. The problem is, the server didn't transfer the header as-is, so the data got lost. I added code to transfer the headers as-is, but to avoid massive commit, I left all the server messages as-is, only changed processing messages from clients. Changes: - RoRnet updated to support new timestamps - Messaging: added `SendMessageWithHeader()` - Broadcaster - transformed `QueueMessage()` with separate values to `QueuePacket` with header. - Sequencer - accept and broadcast the entire header. Added `sendStreamData()` helper for that.
|
Closing this as stale and not immediatelly useful - there is a multitude of things waiting to be integrated into RoRnet (tuning, character mods, the teleporting pieces fix) and there are further plans for porting to ENet and adding multiplayer collisions, all of which need to be started clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a spinoff from #3055
Requires updated rorserver - see RigsOfRods/ror-server#152
New features:
RoRnet::Header- all packets now track their time shift between remote client and local client. Note that the existing truck time shift tracking made by Ulteq is unchanged for now.RoRnet::Header- all packets now track the delay between creating the packet and transmitting it to server.NetRecvPacket- all packets now track local delay between receiving packet and processing it.Motivation:
ActorandActorManager.Character,Actor,ActorManager- the pattern is not clear).Time spent: 6.5hours, not counting rorserver.