support for HID SAM communication with SEOS cards #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are welcome to add an entry to the CHANGELOG.md as well |
iceman1001
reviewed
Jan 4, 2025
|
You also got a breaking build.
|
I put a cast there now to silence the warning, as it's big enough. I'll cleanup unnecessary code duplication between |
|
Lemme know when you think you are ready for merge |
jkramarz
force-pushed
the
feature/sam_seos
branch
2 times, most recently
from
8c1fa63 to
2539c66
Compare
jkramarz
changed the title
|
@iceman1001, it's cleaned up and rebased. |
…ed on bettse/seader project
As described in 5326-903 OMNIKEY 5326 Software Developer Guide (https://www.hidglobal.com/documents/omnikey-5326-dfr-developers-guide). Seems like it should be here since the beginning, but worked fine without.
As PLT-03273 OMNIKEY 5023 Software Developer Guide (https://www.hidglobal.com/documents/omnikey-5023-software-developer-guide) describes a command that returns additional information about SIO object containing PACS data, switching to more verbose one.
jkramarz
force-pushed
the
feature/sam_seos
branch
from
abdabac to
13e390a
Compare
|
Excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.