Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contextual music rarity #5609

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Add contextual music rarity #5609

merged 5 commits into from
Oct 21, 2024

Conversation

CI09
Copy link
Contributor

@CI09 CI09 commented Oct 18, 2024

Brief Description of What This PR Does

Adds rarity constant and math for it

Related Issues

Closes #5552

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@CI09 CI09 added the review label Oct 18, 2024
@CI09 CI09 added this to the Release 0.7.1 milestone Oct 18, 2024
@CI09 CI09 requested review from a team October 18, 2024 17:10
@revolutionary-bot
Copy link

We are currently in feature freeze until the next release.
If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

Copy link
Member

@dligr dligr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this to work in game. Code changes make sense to me too.

and I added a TODO comment about fixing the music repeats caused by the system
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the memory handling and code clarity here. I also added a TODO comment about fixing playing the same track over and over with this new code: #5615

I'll merge this now and assume my changes didn't break the actual functionality here.

@hhyyrylainen hhyyrylainen merged commit b56b993 into master Oct 21, 2024
4 checks passed
@hhyyrylainen hhyyrylainen deleted the contextual_music_rarity branch October 21, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make context specific music tracks more likely to play in the microbe stage
4 participants