Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retroarch: add core info files to configuration #3549

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

cmitu
Copy link
Contributor

@cmitu cmitu commented Jun 13, 2022

Core info files are needed starting from 1.10.1 in order to enable save/load state, rewind, runahead, (disk control ?).
In addition to that, they're needed for netplay clients to work (see issue #3161).

NOTE: this PR and #3548 should fix issue #3161.

@cmitu
Copy link
Contributor Author

cmitu commented Jun 13, 2022

Adding the info files will enable the start-up info to pop-up:

image

If we don't want that, I can add the retroarch.cfg parameter to disable it, should be easy to find (tm).

@joolswills
Copy link
Member

I'm not sure. It may be best to disable it by default to keep current behaviour.

@cmitu cmitu marked this pull request as draft June 15, 2022 12:27
Core info files are needed starting from 1.10.1 in order to enable save/load state, rewind, runahead, (disk control ?).
In addition to that, they're needed for netplay clients to work (see issue RetroPie#3161).
@cmitu cmitu force-pushed the retroarch-updates branch from d9e0a56 to 55aab04 Compare June 15, 2022 17:39
@cmitu
Copy link
Contributor Author

cmitu commented Jun 15, 2022

@joolswills ok, added the config option to quiesce the info blurb.

I also checked the libretro cores that we ship and the upstream repository is missing a few .info files:

  • mess and mess2016. We can clone them based on mame and mame2016.
  • superflappybirds. No idea what are the capabilities, I'll have to give it a spin.
  • mupen64plus. We can clone it from mupen64plus-next.

My idea for the missing core info files is to generate them from the scriptmodule, via configure, instead of adding them in retroarch. Apart from the mupen64plus core, they're not installed by default.

@cmitu cmitu marked this pull request as ready for review June 15, 2022 17:44
@joolswills joolswills merged commit 2a5fb72 into RetroPie:master Jun 15, 2022
@joolswills
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants