Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-2176] Skip graphics capture if graphics not available #354

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

vontell
Copy link
Collaborator

@vontell vontell commented Nov 12, 2024

Sorry this took so long, took a while to iterate since building the game fully takes 15 minutes or so, and my approach of doing an early conditional break was acting up, so went with the more safe approach of just wrapping it in an if statement. Tested this in BossRoom and seems to work, and in our user's game, the game itself still doesn't work, but the graphics error is no longer thrown. There may be more changes to come, TBD, but this gets us partway there.

@vontell vontell marked this pull request as ready for review November 12, 2024 17:09
@vontell vontell requested a review from nAmKcAz as a code owner November 12, 2024 17:09
Copy link
Contributor

@batu batu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add, pending Zack's comments

@vontell vontell requested a review from nAmKcAz November 15, 2024 16:52
@nAmKcAz
Copy link
Collaborator

nAmKcAz commented Nov 15, 2024

@vontell I see you re-tagged me for review, but that seems to conflict with your comments above about still testing this. I'd prefer to only re-review this one time so please request again once all testing/changes are done.

@nAmKcAz nAmKcAz removed their request for review November 15, 2024 19:12
Copy link
Contributor

@abeizer abeizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting so slack bot stops pinging me until this is ready

@vontell
Copy link
Collaborator Author

vontell commented Nov 24, 2024

Ok this should finally be ready for review. Took a while to get to the cleanest solution, but I believe this would be it... TLDR; my original check would stop both the screenshot read and onCompletion handlers from being called ever, meaning that the action handlers that write the ticks to disk also never get called. I've left that check there as a safety precaution, but the main change is that now the onCompletion handlers are called right away in the case when graphics are not available.

@vontell vontell requested review from nAmKcAz, abeizer and batu November 24, 2024 18:58
@vontell
Copy link
Collaborator Author

vontell commented Nov 25, 2024

@RG-nAmKcAz edits made 👍

@vontell vontell requested a review from nAmKcAz November 25, 2024 15:25
@vontell
Copy link
Collaborator Author

vontell commented Nov 25, 2024

Also just tested on Windows, this works there as well

@vontell vontell merged commit c15a2ce into main Nov 26, 2024
2 checks passed
@vontell vontell deleted the aaron/reg-2176 branch November 26, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants