-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REG-2180] Add monkey bot action space analysis results #353
Conversation
This is step 1.5 in getting to where we have the data to drive more 'intelligent' exploration bots for games. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall to me, but I would love to see a video overall as I haven't really seen it in action. (I believe Sasha finished these right around the time I joined)
It also occurred to me now that Runespawn can be used in conjunction botSequences, I can pass in int segmentNumber in Simulation interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very excited to see this get in! The ability to automatically gather more useful data during a monkey test will be very valuable, especially as we start to add more and more to this foundation.
I'm especially excited to see what ideas folks have on the code coverage part - that information could be really valuable (i.e. pointing the developer to parts of the code in a nice UI or format related to a particular validation).
During our 1:1 it'd be great to dive deeper into any observations and ideas you have. Curious to hear what potential next steps would be.
@@ -270,6 +280,7 @@ private async Task HandleEndRecording(long tickCount, | |||
_needToRefreshAssets = true; | |||
#endif | |||
|
|||
//TODO (REG-2181): Add upload logic for metadata like action analysis, code coverage, etc - we probably also want consider if we redo the game metadata upload here and roll these into a single zip file of metadata ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I wonder if it might get messy with the number of zip files we are uploading now... something to think about.
usedActions
report for each tick at some future pointFind the pull request instructions here
Every reviewer and the owner of the PR should consider these points in their request (feel free to copy this checklist so you can fill it out yourself in the overall PR comment)