Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1530] Reformat all C# code to match 'dotnet-format' style #127

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

analogrelay
Copy link
Contributor

This is a PR to ashley/refmt. That means merging this PR will add these comments to the existing #126 .

I separated these out because this PR is all automated code formatting changes, which are quite noisy. This change was entirely generated via the official 'dotnet format' C# reformatting tool. So, it's worth a scan, but between this and the build process, we can have some faith that it's safe.

When this and #126 are approved separately, I'll merge both in together.


Find the pull request instructions here

Every reviewer and the owner of the PR should consider these points in their request (feel free to copy this checklist so you can fill it out yourself in the overall PR comment)

  • The code is extensible and backward compatible
  • New public interfaces are extensible and open to backward compatibility in the future
  • If preparing to remove a field in the future (i.e. this PR removes an argument), the argument stays but is no longer functional, and attaches a deprecation warning. A linear task is also created to track this deletion task.
  • Non-critical or potentially modifiable arguments are optional
  • Breaking changes and the approach to handling them have been verified with the team (in the Linear task, design doc, or PR itself)
  • The code is easy to read
  • Unit tests are added for expected and edge cases
  • Integration tests are added for expected and edge cases
  • Functions and classes are documented
  • Migrations for both up and down operations are completed
  • A documentation PR is created and being reviewed for anything in this PR that requires knowledge to use
  • Implications on other dependent code (i.e. sample games and sample bots) is considered, mentioned, and properly handled
  • Style changes and other non-blocking changes are marked as non-blocking from reviewers

@analogrelay analogrelay marked this pull request as ready for review December 13, 2023 22:11
@analogrelay
Copy link
Contributor Author

It's actually not too hard to review this with "Hide whitespace" enabled in the PR Files tab.

@analogrelay
Copy link
Contributor Author

Merging this down into the reformat PR.

@analogrelay analogrelay merged commit 91f1fa8 into ashley/refmt Jan 12, 2024
@analogrelay analogrelay deleted the ashley/refmt-clean-up branch January 12, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants