Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated warning for punycode package #1719

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

DmitryAnansky
Copy link
Contributor

What/Why/How?

Fixing deprecated warning for punycode package:

(node:48436) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
    at node:punycode:3:9

Reference

Closes: #1332

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

changeset-bot bot commented Sep 6, 2024

🦋 Changeset detected

Latest commit: dfda807

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DmitryAnansky DmitryAnansky changed the title fix: update redocly-ajv package fix: deprecated warning for punycode package Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 965.4 ± 15.8 938.2 995.5 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 970.3 ± 18.9 951.8 1003.1 1.01 ± 0.03

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.34% 4901/6256
🟡 Branches 67.04% 2028/3025
🟡 Functions 72.62% 809/1114
🟡 Lines 78.64% 4623/5879

Test suite run success

794 tests passing in 118 suites.

Report generated by 🧪jest coverage report action from dfda807

@DmitryAnansky DmitryAnansky marked this pull request as ready for review September 6, 2024 15:22
@DmitryAnansky DmitryAnansky requested review from a team as code owners September 6, 2024 15:22
@DmitryAnansky DmitryAnansky merged commit e29a7db into main Sep 9, 2024
30 checks passed
@DmitryAnansky DmitryAnansky deleted the fix/update-redocly-ajv branch September 9, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

punycode deprecation warning in node 21
3 participants