fix build for x86 and arm (#110)

* fix the right define * fixed the include * removed cpu_features macros include * incdlue cpu_features macros * fixed x86 build
RedisAI · Jan 5, 2022 · 112b7ea · 112b7ea
1 parent b4dfb45
commit 112b7ea
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/VecSim/spaces/space_aux.cpp b/src/VecSim/spaces/space_aux.cpp
@@ -1,8 +1,13 @@
 #include "space_aux.h"
+#include "cpu_features_macros.h"
+
+#ifdef CPU_FEATURES_ARCH_X86_64
+#include "cpuinfo_x86.h"
+#endif // CPU_FEATURES_ARCH_X86_64
 
 Arch_Optimization getArchitectureOptimization() {
 
-#ifdef CPU_FEATURES_ARCH_X86
+#ifdef CPU_FEATURES_ARCH_X86_64
 #include "cpuinfo_x86.h"
     cpu_features::X86Features features = cpu_features::GetX86Info().features;
     if (features.avx512f) {
@@ -13,7 +18,7 @@ Arch_Optimization getArchitectureOptimization() {
                features.sse4_2 || features.sse4a) {
         return ARCH_OPT_SSE;
     }
-#endif // CPU_FEATURES_ARCH_X86
+#endif // CPU_FEATURES_ARCH_X86_64
 
     return ARCH_OPT_NONE;
 }
diff --git a/tests/unit/test_spaces.cpp b/tests/unit/test_spaces.cpp
@@ -1,4 +1,5 @@
 #include "gtest/gtest.h"
+#include "cpu_features_macros.h"
 #include "VecSim/spaces/space_aux.h"
 #include "VecSim/spaces/IP/IP.h"
 #include "VecSim/spaces/IP/IP_SSE.h"
@@ -21,7 +22,7 @@ class SpacesTest : public ::testing::Test {
     void TearDown() override {}
 };
 
-#ifdef CPU_FEATURES_ARCH_X86
+#ifdef CPU_FEATURES_ARCH_X86_64
 // This test will trigger the "Residuals" function for dimension > 16, for each optimization.
 TEST_F(SpacesTest, l2_17) {
     Arch_Optimization optimization = getArchitectureOptimization();
@@ -121,4 +122,4 @@ TEST_F(SpacesTest, ip_9) {
         ASSERT_TRUE(false);
     }
 }
-#endif // CPU_FEATURES_ARCH_X86
+#endif // CPU_FEATURES_ARCH_X86_64