Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clear input for number type #265

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

LightOfHeaven1994
Copy link
Collaborator

Ctrl + A is generally used to select text. In number input fields, the browser does not treat the numeric value as selectable text, which is why Ctrl + A doesn't work.

Bug has been found when debugging test that tries to navigate to specific page using pagination input

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (ee52664) to head (4b8c05d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   86.76%   86.78%   +0.01%     
==========================================
  Files          18       18              
  Lines        2569     2572       +3     
==========================================
+ Hits         2229     2232       +3     
  Misses        340      340              
Flag Coverage Δ
unittests 86.78% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM 👍

@LightOfHeaven1994 LightOfHeaven1994 merged commit d149b5d into main Sep 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants