Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSIDB-3806] Flaw contributors table #531

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

MrMarble
Copy link
Member

@MrMarble MrMarble commented Jan 24, 2025

Flaw contributors table

Checklist:

  • Commits consolidated
  • Changelog updated
  • Test cases added/updated
  • Jira ticket updated

Summary:

Added the Flaw contributors table to the edit view

Changes:

image
image
image

Considerations:

Closes OSIDB-3806

@MrMarble MrMarble self-assigned this Jan 24, 2025
@MrMarble MrMarble force-pushed the feature/OSDIB-3806 branch 2 times, most recently from a8322cb to af07b55 Compare January 24, 2025 15:56
@MrMarble MrMarble marked this pull request as ready for review January 24, 2025 16:03
@MrMarble MrMarble requested a review from a team January 24, 2025 16:03
@@ -257,6 +258,7 @@ const createdDate = computed(() => {
:error="errors.source"
:options-hidden="hiddenSources"
/>
<FlawLabelsTable v-if="mode==='edit'" v-model="flaw.labels!" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<FlawLabelsTable v-if="mode==='edit'" v-model="flaw.labels!" />
<FlawLabelsTable v-if="flaw.uuid" v-model="flaw.labels!" />

Think we could shift away from using the mode prop

Copy link
Collaborator

@superbuggy superbuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on 2nd pass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants