custom validations before standard ones #905
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which also means that the data conversion must happen independently outside of the standard validations
osoukup
force-pushed
the
affect-reunion
branch
from
fa810c7 to
5634788
Compare
osoukup
added
the
technical
|
@jobselko FYI we discussed this quite recently. I have to admit that it was not really easy to change the validation order 😅 but it was necessary so I can later create dummy affects |
MrMarble
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the order of the validations. The standard Django validations which were run through full_clean are now postponed after the custom ones. The reason is that the custom ones provide more refined error messages and if we run them after the standard ones the user can get an error which is not really the correct one.
This was the reason why there was one affect validation run in the save method however that was breaking the concept of the AlertMixin where there is an option to suppress the exception and only store the alert. This PR comes as a prerequisite of the orphaned tracker linking where a dummy affects will need to be automatically created and they will possibly be partially invalid due to a missing information. A non-suppressible exception is a blocker.