Validate flaw impact and RH CVSSv3 score properly #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobselko
changed the title
jobselko
commented
Jan 23, 2025
There was a problem hiding this comment.
FYI, I chose not to modify FlawFactory to automatically create RH CVSSv3 if necessary, as this change would break many tests and fixing it would be difficult due to the non-deterministic nature of the tests.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
This PR fixes/removes the clumsy changes introduced in #825. These changes (and some code around) are no longer needed because #890 changed how the `FlawCVSS` model is validated. Instead of validating all CVSS scores, only the RH CVSS3 score is validated. The NVD collector only touches NIST CVSS scores, so no code adjustments are required. Closes OSIDB-3678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the flaw's impact and RH CVSSv3 score validations as they are currently inconsistent and incomplete.
If RH CVSSv3 is present, score and impact should comply with the following:
Closes OSIDB-3738