Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove webpack dependancies because they are not needed #2205

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Fewwy
Copy link
Contributor

@Fewwy Fewwy commented Feb 11, 2025

  1. According to the discussion we had on slack -> we need to remove webpack deps because we don't need it
  2. Add unstable spdy to fec config

@Fewwy Fewwy self-assigned this Feb 11, 2025
Copy link

jira-linking bot commented Feb 11, 2025

Commits missing Jira IDs:
475a635
03ed22c
42ec8e0
f0871f9

@Fewwy Fewwy changed the title chore(deps): remove webpack dependancies because they are not necessary chore(deps): remove webpack dependancies because they are not needed Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.09%. Comparing base (e321bcf) to head (a94f14e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2205   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files         128      128           
  Lines        3491     3491           
  Branches     1108     1108           
=======================================
  Hits         2412     2412           
  Misses       1079     1079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fewwy Fewwy added the dependencies Pull requests that update a dependency file label Feb 11, 2025
@Fewwy Fewwy requested a review from a team as a code owner February 12, 2025 12:42
@LightOfHeaven1994
Copy link
Contributor

/retest

fec.config.js Outdated Show resolved Hide resolved
@bastilian
Copy link
Member

@Fewwy I think we'll need to run rm -rf node_modules && rm package-lock.json && npm install. The request are still HTTP 1.1, probably because there are some outdated deps lingering in the lock file.

@Fewwy Fewwy force-pushed the remove-webpack-deps branch from 9f52aeb to f0871f9 Compare February 14, 2025 13:45
@Fewwy Fewwy force-pushed the remove-webpack-deps branch from 2247a52 to 21aecce Compare February 14, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants