-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(OperatingSystemFilter): RHINENG-2912 - Fix OS inventory filter conversion #2065
Conversation
Referenced Jiras: |
30e68b1
to
10729e2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
+ Coverage 67.07% 67.15% +0.07%
==========================================
Files 128 128
Lines 3432 3440 +8
Branches 1064 1067 +3
==========================================
+ Hits 2302 2310 +8
Misses 1130 1130 ☔ View full report in Codecov by Sentry. |
10729e2
to
65cfe83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filter works like a charm. When I remove one of the applied OS using filter chip X button, error pops up with a message 'TypeError
Cannot read properties of undefined (reading 'filter')'. It would be great if we fix it before merge. I have screen video if you need more context on how to reproduce. Ping if it is needed.
65cfe83
to
ebb148e
Compare
@mkholjuraev Thank you for reviewing and testing! The issue with chip deletion is now fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I did not encounter any issues @bastilian thank you.
This fixes the OS filter on the Systems Page.
How to test: