Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OperatingSystemFilter): RHINENG-2912 - Fix OS inventory filter conversion #2065

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

bastilian
Copy link
Member

@bastilian bastilian commented Jan 19, 2024

This fixes the OS filter on the Systems Page.

How to test:

  1. Open the Systems Page
  2. Select combinations of OS versions
  3. Verify that the filters is converted and passed to the API

Copy link

jira-linking bot commented Jan 19, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-2912

@bastilian bastilian changed the title fix(OperatingSystemFilter): RHINENG-2912 - Fix OS inventory filter co… fix(OperatingSystemFilter): RHINENG-2912 - Fix OS inventory filter conversion Jan 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.15%. Comparing base (bafe7f7) to head (ebb148e).
Report is 2 commits behind head on master.

Files Patch % Lines
src/Helpers/Hooks.js 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2065      +/-   ##
==========================================
+ Coverage   67.07%   67.15%   +0.07%     
==========================================
  Files         128      128              
  Lines        3432     3440       +8     
  Branches     1064     1067       +3     
==========================================
+ Hits         2302     2310       +8     
  Misses       1130     1130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bastilian bastilian marked this pull request as ready for review July 18, 2024 10:28
@bastilian bastilian requested a review from a team as a code owner July 18, 2024 10:28
Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter works like a charm. When I remove one of the applied OS using filter chip X button, error pops up with a message 'TypeError
Cannot read properties of undefined (reading 'filter')'. It would be great if we fix it before merge. I have screen video if you need more context on how to reproduce. Ping if it is needed.

@bastilian
Copy link
Member Author

@mkholjuraev Thank you for reviewing and testing! The issue with chip deletion is now fixed!

Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I did not encounter any issues @bastilian thank you.

@bastilian bastilian merged commit 40d2bae into RedHatInsights:master Jul 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants