Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): move all rtl deps to dev dependecies #2051

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

mkholjuraev
Copy link
Contributor

Somehow RTL related packages were not installed as dev dependency. This PR moves them to dev dependencies.

@mkholjuraev mkholjuraev requested a review from a team as a code owner December 6, 2023 22:16
Copy link

jira-linking bot commented Dec 6, 2023

Commits missing Jira IDs:
86d8646

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6f3269) 71.81% compared to head (86d8646) 71.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2051   +/-   ##
=======================================
  Coverage   71.81%   71.81%           
=======================================
  Files         128      128           
  Lines        3370     3370           
  Branches     1038     1038           
=======================================
  Hits         2420     2420           
  Misses        950      950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkholjuraev

@mkholjuraev mkholjuraev merged commit 710907f into RedHatInsights:master Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants