Fix table API requests firing twice upon changing page

RedHatInsights · Mar 1, 2024 · bf870af · bf870af
1 parent ec79ca0
commit bf870af
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/Helpers/hooks.js b/src/Helpers/hooks.js
@@ -131,9 +131,13 @@ export const useUrlBoundParams = ({
   const dispatch = useDispatch();
 
   const [getUrlParams, setUrlParams] = useUrlParams(allowedParams);
+  const [isFirstLoad, setFirstLoad] = useState(true);
 
+  // if a user clicks on the currently loaded page in the navbar,
+  // page would not refresh, but the URL would clear; this useEffect
+  // solves this inconsistent state
   useEffect(() => {
-    if (window.location.search === '') {
+    if (!isFirstLoad && window.location.search === '') {
       apply({ ...initialParams });
     }
   }, [window.location.search]);
@@ -142,6 +146,7 @@ export const useUrlBoundParams = ({
     const initialUrlParams = getUrlParams();
 
     apply({ ...initialParams, ...initialUrlParams });
+    setFirstLoad(false);
   }, []);
 
   const apply = (newParams, isReset = false) => {