fix(client): Status code should indicate registration status #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4344 +/- ##
=======================================
Coverage 77.06% 77.07%
=======================================
Files 736 736
Lines 41368 41369 +1
Branches 8789 8789
=======================================
+ Hits 31881 31884 +3
+ Misses 8428 8427 -1
+ Partials 1059 1058 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
added
the
client
|
test me |
pkoprda
force-pushed
the
registration-status
branch
from
39e2165 to
3bc26f0
Compare
m-horky
approved these changes
Jan 27, 2025
zpetrace
approved these changes
Jan 31, 2025
* Card ID: CCT-1059 Status code returned by `insights-client --status` should indicate whether a host is registered or not. This change ensures that the exit code is 0 if the host is registered and 1 if it is not. Signed-off-by: pkoprda <[email protected]>
pkoprda
force-pushed
the
registration-status
branch
from
3bc26f0 to
c221139
Compare
|
@xiangce we can merge :) |
|
Ignoring the smoke test failure as it's WIP and merging |
xiangce
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Card ID: CCT-1059 Status code returned by `insights-client --status` should indicate whether a host is registered or not. This change ensures that the exit code is 0 if the host is registered and 1 if it is not. Signed-off-by: pkoprda <[email protected]> (cherry picked from commit dc41f82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Status code returned by
insights-client --statusshould indicate whether a host is registered or not. This change ensures that the exit code is 0 if the host is registered and 1 if it is not.