Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor: resort the manifests for malware-detection and compliance #4336

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Jan 15, 2025

  • add canonical facts to persist collection
  • resort the specs order

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add your description here

- add canonical facts to persist collection
- resort the specs order

Signed-off-by: Xiangce Liu <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.05%. Comparing base (9e933da) to head (83f0a84).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4336   +/-   ##
=======================================
  Coverage   77.05%   77.05%           
=======================================
  Files         736      736           
  Lines       41363    41363           
  Branches     8787     8787           
=======================================
  Hits        31874    31874           
  Misses       8431     8431           
  Partials     1058     1058           
Flag Coverage Δ
unittests 77.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangce xiangce added the QE label Jan 15, 2025
@xiangce xiangce changed the title chore: resort the manifests for malware-detection and compliance [WIP] chore: resort the manifests for malware-detection and compliance Jan 15, 2025
@xiangce xiangce changed the title [WIP] chore: resort the manifests for malware-detection and compliance [WIP] refactor: resort the manifests for malware-detection and compliance Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants