Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont use magic HTTP constants in code #548

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Dont use magic HTTP constants in code #548

merged 3 commits into from
Dec 20, 2023

Conversation

tisnik
Copy link
Collaborator

@tisnik tisnik commented Dec 20, 2023

Description

Dont use magic HTTP constants in code

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

N/A

Checklist

  • Pylint passes for Python sources
  • sources has been pre-processed by Black
  • updated documentation wherever necessary
  • new tests can be executed both locally and within docker container
  • new tests have been included in scenario list (make update-scenarios)

@tisnik tisnik merged commit e52fe4d into RedHatInsights:main Dec 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiriPapousek JiriPapousek JiriPapousek approved these changes

@juandspy juandspy juandspy approved these changes

@Bee-lee Bee-lee Awaiting requested review from Bee-lee

@joselsegura joselsegura Awaiting requested review from joselsegura

@matysek matysek Awaiting requested review from matysek

@epapbak epapbak Awaiting requested review from epapbak

@Jakub007d Jakub007d Awaiting requested review from Jakub007d

@falox falox Awaiting requested review from falox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tisnik @JiriPapousek @juandspy