Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(RHINENG-15692): Cleanup Reports component #2374

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LightOfHeaven1994
Copy link
Contributor

  1. Cleanup Reports component
  2. Make all cypress tests work again but with V2

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the cleanup-reports-component branch from 563dd82 to e1a1faa Compare February 3, 2025 20:01
@LightOfHeaven1994 LightOfHeaven1994 marked this pull request as ready for review February 3, 2025 22:09
@LightOfHeaven1994 LightOfHeaven1994 force-pushed the cleanup-reports-component branch from 7483e31 to 3aeebd8 Compare February 3, 2025 22:13
@LightOfHeaven1994 LightOfHeaven1994 changed the title chore(RHINENG-15653): Cleanup Reports component chore(RHINENG-15692): Cleanup Reports component Feb 3, 2025
@LightOfHeaven1994 LightOfHeaven1994 requested a review from a team February 3, 2025 22:14
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.26%. Comparing base (ba708a4) to head (4f43147).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2374      +/-   ##
==========================================
+ Coverage   66.94%   67.26%   +0.32%     
==========================================
  Files         359      358       -1     
  Lines        6332     6309      -23     
  Branches     2012     2005       -7     
==========================================
+ Hits         4239     4244       +5     
+ Misses       2093     2065      -28     
Flag Coverage Δ
combined 67.26% <100.00%> (+0.32%) ⬆️
cypress 35.42% <100.00%> (-6.60%) ⬇️
jest 66.08% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the cleanup-reports-component branch from 3aeebd8 to 22023d0 Compare February 4, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants