-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename
BindableState
to BindingState
(#1855)
The -`able` naming evokes protocols in Swift, and is an outlier when considered alongside the rest of TCA's binding tools: - `BindingAction`: concrete type - `BindableAction`: protocol - `BindingReducer`: concrete type So, let's make things consistent. The one caveat is that Swift diagnostics for such a deprecation aren't great, so users won't get proactive warnings here for the time being: swiftlang/swift#63139 We may just want to keep the deprecation around till it does... (cherry picked from commit 52c4a01437aa1429dab4e6b460062a8b7d6aeab6) # Conflicts: # Sources/ComposableArchitecture/Internal/Deprecations.swift # Sources/ComposableArchitecture/SwiftUI/Binding.swift # Tests/ComposableArchitectureTests/DebugTests.swift
- Loading branch information
1 parent
37d99ca
commit 90ea5d4
Showing
9 changed files
with
649 additions
and
641 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.