-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hierarchical BLR #206
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB bartvanerp commented on 2024-01-04T10:01:59Z There are some versioning issues here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the updated notebooks failed to execute as it does not know the infer function. I guess this has something to do with the versioning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 80.31% 80.31%
=======================================
Files 11 11
Lines 1290 1290
=======================================
Hits 1036 1036
Misses 254 254 ☔ View full report in Codecov by Sentry. |
@bartvanerp, perhaps that's because the new version of |
@bartvanerp I see that tests for examples pass in CI. |
Hmm that's strange, in the notebook viewer it says that some cells failed. I don't think this reruns the code. |
Not sure why it happens then. It went well here #190 |
The pushed notebook seems to contain the same errors: https://github.com/biaslab/RxInfer.jl/blob/fix-hlr-example/examples/basic_examples/Bayesian%20Linear%20Regression%20Tutorial.ipynb |
This PR fixes minor mistakes with Hierarchical Bayesian Linear Regression that we found following the discussion #199