Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hierarchical BLR #206

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Update Hierarchical BLR #206

merged 2 commits into from
Jan 5, 2024

Conversation

albertpod
Copy link
Member

This PR fixes minor mistakes with Hierarchical Bayesian Linear Regression that we found following the discussion #199

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Jan 4, 2024

View / edit / reply to this conversation on ReviewNB

bartvanerp commented on 2024-01-04T10:01:59Z
----------------------------------------------------------------

There are some versioning issues here


@bartvanerp bartvanerp self-requested a review January 4, 2024 10:03
Copy link
Member

@bartvanerp bartvanerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the updated notebooks failed to execute as it does not know the infer function. I guess this has something to do with the versioning

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afa07ef) 80.31% compared to head (0dbccb5) 80.31%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   80.31%   80.31%           
=======================================
  Files          11       11           
  Lines        1290     1290           
=======================================
  Hits         1036     1036           
  Misses        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertpod
Copy link
Member Author

albertpod commented Jan 4, 2024

@bartvanerp, perhaps that's because the new version of RxInfer.jl hasn't been released; examples look into the released version.

@albertpod
Copy link
Member Author

@bartvanerp I see that tests for examples pass in CI.

@bartvanerp
Copy link
Member

Hmm that's strange, in the notebook viewer it says that some cells failed. I don't think this reruns the code.

@albertpod
Copy link
Member Author

Not sure why it happens then. It went well here #190

@bartvanerp
Copy link
Member

bartvanerp commented Jan 4, 2024

The pushed notebook seems to contain the same errors: https://github.com/biaslab/RxInfer.jl/blob/fix-hlr-example/examples/basic_examples/Bayesian%20Linear%20Regression%20Tutorial.ipynb
Did you remove the manifest.toml file in the examples folder before running the notebook?

@albertpod albertpod merged commit 04bd878 into main Jan 5, 2024
7 checks passed
@albertpod albertpod deleted the fix-hlr-example branch January 5, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants