Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev add re test items #196

Merged
merged 10 commits into from
Nov 28, 2023
Merged

Dev add re test items #196

merged 10 commits into from
Nov 28, 2023

Conversation

mhidalgoaraya
Copy link
Contributor

Using ReTestItems package for all of the tests

@mhidalgoaraya mhidalgoaraya added the enhancement New feature or request label Nov 27, 2023
@mhidalgoaraya mhidalgoaraya added this to the RxInfer update Nov 28th milestone Nov 27, 2023
@mhidalgoaraya mhidalgoaraya linked an issue Nov 27, 2023 that may be closed by this pull request
Project.toml Outdated
@@ -58,6 +58,7 @@ StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
StatsFuns = "4c63d2b9-4356-54db-8cca-17b64c39e42c"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
TestSetExtensions = "98d24dd4-01ad-11ea-1b02-c9a08f80db04"
ReTestItems = "817f1d60-ba6b-4fd5-9520-3cf149f6a823"

[targets]
test = ["Test", "Pkg", "Logging", "InteractiveUtils", "TestSetExtensions", "Coverage", "Dates", "Distributed", "Documenter", "Plots", "BenchmarkCI", "BenchmarkTools", "PkgBenchmark", "Aqua", "StableRNGs", "StatsFuns", "Optimisers"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test = ["Test", "Pkg", "Logging", "InteractiveUtils", "TestSetExtensions", "Coverage", "Dates", "Distributed", "Documenter", "Plots", "BenchmarkCI", "BenchmarkTools", "PkgBenchmark", "Aqua", "StableRNGs", "StatsFuns", "Optimisers"]
test = ["Test", "ReTestItems", "Pkg", "Logging", "InteractiveUtils", "TestSetExtensions", "Coverage", "Dates", "Distributed", "Documenter", "Plots", "BenchmarkCI", "BenchmarkTools", "PkgBenchmark", "Aqua", "StableRNGs", "StatsFuns", "Optimisers"]

Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add the "ReTestItems" to the "test" target

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e6488d) 80.23% compared to head (d6d8e23) 80.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   80.23%   80.31%   +0.07%     
==========================================
  Files          11       11              
  Lines        1285     1285              
==========================================
+ Hits         1031     1032       +1     
+ Misses        254      253       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mhidalgoaraya and @Chengfeng-Jia . Great job!

@bvdmitri bvdmitri merged commit 9b7e1e8 into main Nov 28, 2023
7 checks passed
@bvdmitri bvdmitri deleted the dev-add-ReTestItems branch November 28, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ReTestItems for tests
3 participants