Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI artifact actions to v4 #674

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Update CI artifact actions to v4 #674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9927aa4
update CI to use upload artifacts v4
jonwzheng Jan 13, 2025
cd4b6a7
fix runner bug by symlinking libtiff.so.6 to libtiff.so.5
jonwzheng Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ jobs:
mamba info
mamba list

- name: Make libtiff Symlink to Avoid Runner Bug
run: | # This action may need to be removed/adjusted in future runs.
if [ ! -f /usr/lib/x86_64-linux-gnu/libtiff.so.5 ] && [ -f /usr/lib/x86_64-linux-gnu/libtiff.so.6 ]; then sudo ln -s /usr/lib/x86_64-linux-gnu/libtiff.so.6 /usr/lib/x86_64-linux-gnu/libtiff.so.5; fi
find /usr/lib -name libtiff*

# modify env variables as directed in the RMG installation instructions
- name: Set Environment Variables
run: |
Expand Down Expand Up @@ -130,7 +135,7 @@ jobs:
# Upload Regression Results as Failed if above step failed
- name: Upload Failed Results
if: ${{ failure() && steps.regression-execution.conclusion == 'failure' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: failed_regression_results
path: |
Expand All @@ -139,7 +144,7 @@ jobs:
# Upload Regression Results as Dynamic if Push to non-main Branch
- name: Upload Results as Dynamic
if: ${{ env.REFERENCE_JOB == 'false' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dynamic_regression_results
path: |
Expand Down Expand Up @@ -269,14 +274,14 @@ jobs:

- name: Upload regression summary artifact
# the annotate workflow uses this artifact to add a comment to the PR
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if : ${{ github.event_name == 'pull_request' }}
with:
name: regression_summary
path: RMG-Py/summary.txt

- name: Upload Comparison Results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: regression_test_comparison_results
path: |
Expand Down
Loading