use warning instead of stop

RcppCore · Jun 18, 2024 · bc529e0 · bc529e0
1 parent 69cb4dd
commit bc529e0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/inst/include/Rcpp/vector/traits.h b/inst/include/Rcpp/vector/traits.h
@@ -56,7 +56,7 @@ namespace traits{
 		void check_index(R_xlen_t i) const {
 #ifndef RCPP_NO_BOUNDS_CHECK
 			if (i >= size) {
-				stop("subscript out of bounds (index %s >= vector size %s)", i, size);
+				warning("subscript out of bounds (index %s >= vector size %s)", i, size);
 			}
 #endif
 		}
@@ -94,7 +94,7 @@ namespace traits{
 		void check_index(R_xlen_t i) const {
 #ifndef RCPP_NO_BOUNDS_CHECK
 			if (i >= p->size()) {
-				stop("subscript out of bounds (index %s >= vector size %s)", i, p->size());
+				warning("subscript out of bounds (index %s >= vector size %s)", i, p->size());
 			}
 #endif
 		}

diff --git a/inst/tinytest/test_vector.R b/inst/tinytest/test_vector.R
@@ -696,8 +696,9 @@ expect_true( !CharacterVector_test_equality("foo", "bar") )
 expect_true( !CharacterVector_test_equality_crosspolicy("foo", "bar") )
 
 # https://github.com/RcppCore/Rcpp/issues/1308
-expect_error(NumericVector_test_out_of_bounds_read(numeric(0), 0))
-expect_error(NumericVector_test_out_of_bounds_read(numeric(1), 1))
-expect_error(CharacterVector_test_out_of_bounds_read(character(0), 0))
-expect_error(CharacterVector_test_out_of_bounds_read(character(1), 1))
+# tests disabled since these could trigger UBSAN warnings / crashes
+#expect_warning(NumericVector_test_out_of_bounds_read(numeric(0), 0))
+#expect_warning(NumericVector_test_out_of_bounds_read(numeric(1), 1))
+#expect_warning(CharacterVector_test_out_of_bounds_read(character(0), 0))
+#expect_warning(CharacterVector_test_out_of_bounds_read(character(1), 1))