Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask short contigs when loading TSV abundance #389

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

jakobnissen
Copy link
Member

Previously, the TSV file was expected to only contain the retained contigs. This is confusing for users, since they natually assume the TSV file should contain the same contigs as the composition or the FASTA file. So, also mask the TSV file with the composition metadata mask when loading it.

Closes #388

Previously, the TSV file was expected to only contain the retained contigs.
This is confusing for users, since they natually assume the TSV file should
contain the same contigs as the composition or the FASTA file.
So, also mask the TSV file with the composition metadata mask when loading it.
@jakobnissen jakobnissen merged commit 02a9a6e into master Jan 22, 2025
8 checks passed
@jakobnissen jakobnissen deleted the tsv_filter branch January 22, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inquiry on error
1 participant