-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for POLL_RESULT
messages
#9905
Conversation
…at/poll-results-messages
Needs testing, if everything works then this would be ready. |
I have been testing the PR and it works, so it is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks mostly okay I guess. I'm not sure how I feel about updating the state as a result of it but it's not too egregious so it can stay. It merely needs to document the new message type.
Summary
Adds support for
POLL_RESULT
message types.This also adds more things to
Poll
, such asPoll.victor_answer
, exact vote count onPoll.total_votes
, etc.Checklist