Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for POLL_RESULT messages #9905

Merged
merged 16 commits into from
Jan 19, 2025

Conversation

DA-344
Copy link
Contributor

@DA-344 DA-344 commented Aug 6, 2024

Summary

Adds support for POLL_RESULT message types.

This also adds more things to Poll, such as Poll.victor_answer, exact vote count on Poll.total_votes, etc.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@DA-344
Copy link
Contributor Author

DA-344 commented Aug 28, 2024

Needs testing, if everything works then this would be ready.

@DA-344 DA-344 marked this pull request as ready for review December 8, 2024 14:45
@DA-344
Copy link
Contributor Author

DA-344 commented Dec 8, 2024

I have been testing the PR and it works, so it is ready for review.

Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly okay I guess. I'm not sure how I feel about updating the state as a result of it but it's not too egregious so it can stay. It merely needs to document the new message type.

discord/enums.py Show resolved Hide resolved
@Rapptz Rapptz added the needs review This PR will be reviewed in the future label Jan 15, 2025
@Rapptz Rapptz merged commit afbbc07 into Rapptz:master Jan 19, 2025
8 checks passed
@Rapptz Rapptz removed the needs review This PR will be reviewed in the future label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants