App Premium implementation #9453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took 5 minutes
Implement SKUType and EntitlementType enums
…actually mean and represent
# Conflicts: # discord/sku.py
Rapptz
requested changes
Oct 5, 2023
codeofandrin
reviewed
Oct 8, 2023
There was a problem hiding this comment.
- Updated fields from following PR: Premium Apps: SKU and Entitlement fields discord/discord-api-docs#6477
- Improvement suggestions
Co-authored-by: Andrin S. <[email protected]>
Document SKUFlags
Add missing import of annotations future in types/sku.py
I'd say we better wait for an official approval of this PR. |
|
That PR is by an employee. |
My bad. Missed the contributor tag. Then gonna add these changes. |
Co-authored-by: Andrin S. <[email protected]>
Remove consumed and add deleted instead
Rapptz
requested changes
Oct 19, 2023
There was a problem hiding this comment.
Minor doc nits.
There's a bit of a gotcha with the design if someone decides to save Entitlement instances to a variable somewhere since those instances aren't ever updated with gateway information those instances will became stale. It's not an issue with this PR, but it's something to keep in mind.
Co-authored-by: Danny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This represent the implementation of App Subscriptions/App Premium.
I was already able to test the implementation, since I got invited to join the Beta. Based on my tests, everything should work flawlessly.
This PR may need improvements regarding util methods, which interconnect models and simplify the workflow with entitlements.
Checklist