Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for AutoMod Members #9328

Merged
merged 17 commits into from
Oct 19, 2023
Merged

Support for AutoMod Members #9328

merged 17 commits into from
Oct 19, 2023

Conversation

codeofandrin
Copy link
Contributor

@codeofandrin codeofandrin commented Apr 2, 2023 •
edited
Loading

Summary

This PR adds support for AutoMod Members. This also adds the new param mention_raid_protection in AutoModTrigger.
Related PR: discord/discord-api-docs#6040

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@codeofandrin codeofandrin changed the title Support fot AutoMod Members Support for AutoMod Members Apr 2, 2023
@codeofandrin codeofandrin marked this pull request as ready for review April 3, 2023 08:42
bijij
bijij reviewed Apr 8, 2023
View reviewed changes
Copy link
Contributor

@bijij bijij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very against making a breaking change here, not sure what harm there is in still having block_message be the default.

At most I'd say not explicitly passing type should spit back a deprecation warning.

discord/automod.py Show resolved Hide resolved
discord/automod.py Show resolved Hide resolved
redgoldlace
redgoldlace reviewed Apr 8, 2023
View reviewed changes
Copy link
Contributor

@redgoldlace redgoldlace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation aside, I think the documentation could be improved a bit. Nothing major!

docs/api.rst Outdated Show resolved Hide resolved
docs/api.rst Show resolved Hide resolved
docs/api.rst Show resolved Hide resolved
@codeofandrin
Copy link
Contributor Author

I'm very against making a breaking change here, not sure what harm there is in still having block_message be the default.

At most I'd say not explicitly passing type should spit back a deprecation warning.

There's just no reason why block_message should be the default, but since it would be a breaking change, I agree.

@Rapptz Rapptz added the pending PR implements an in-progress or explicitly unreleased Discord feature label Apr 18, 2023
owocado
owocado reviewed Apr 20, 2023
View reviewed changes
discord/automod.py Outdated Show resolved Hide resolved
Rapptz
Rapptz requested changes May 4, 2023
View reviewed changes
discord/automod.py Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Aug 1, 2023

Is there anything still holding this PR back?

@Duued
Copy link

Duued commented Aug 1, 2023

Is there anything still holding this PR back?

You may have forgotten to re-request review from Rapptz

@ghost
Copy link

ghost commented Aug 1, 2023 •
edited by ghost
Loading

Not my PR, just curious about its state since I need this feature.

@codeofandrin
Copy link
Contributor Author

It's still not documented on Discord's side, see here: discord/discord-api-docs#6040

@codeofandrin
Copy link
Contributor Author

codeofandrin commented Oct 8, 2023 •
edited
Loading

This PR can be merged already. The original PR isn't merged yet due to merge conflicts but the "not released" label has been removed, see this comment: discord/discord-api-docs#6040 (comment)

Rapptz
Rapptz requested changes Oct 19, 2023
View reviewed changes
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR just needs to change the 2.3 references to 2.4.

@Rapptz Rapptz removed the pending PR implements an in-progress or explicitly unreleased Discord feature label Oct 19, 2023
@codeofandrin codeofandrin requested a review from Rapptz October 19, 2023 10:35
Rapptz
Rapptz approved these changes Oct 19, 2023
View reviewed changes
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Rapptz Rapptz merged commit 5d35328 into Rapptz:master Oct 19, 2023
8 checks passed
@codeofandrin codeofandrin deleted the automod-changes branch October 21, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owocado owocado owocado left review comments

@Rapptz Rapptz Rapptz approved these changes

@redgoldlace redgoldlace Awaiting requested review from redgoldlace

@bijij bijij Awaiting requested review from bijij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@codeofandrin @Duued @Rapptz @bijij @owocado @redgoldlace