Feature - Raw Presence Updates #10048
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCausc78
reviewed
Dec 21, 2024
LostLuma
reviewed
Dec 21, 2024
LostLuma
reviewed
Dec 22, 2024
Comment on lines
+153
to
+154
| def _create_activities(self, data: PartialPresenceUpdate, state: ConnectionState) -> None: | ||
| self._activities = tuple(create_activity(d, state) for d in data['activities']) |
There was a problem hiding this comment.
I don't think this should be done outside of __init__, as it'll be called on every RawPresenceUpdate anyway since you either dispatch raw_presence_update, call Member._presence_update, or even do both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A current limitation of the library is not being able to listen to presence updates without meeting certain requirements, namely needing both member intents and a member and guild cache. In cases where these requirements are not available or desired, presence updates are still received and discarded. This PR adds functionality for the
on_raw_presence_updateevent, which allows anyone not subscribed to member intents or not using a member or guild cache to receive presence update events.Currently the implementation is semi opt-in, allowing anyone to manually enable or disable raw presences via the new
Clientkeyword parameter. By default this event is only enabled automatically when a user haspresencesintents enabled andmembersintents disabled, as this would mean they could not receive the currently availableon_presence_updateevent.Added
on_raw_presence_updateRawPresenceUpdateEventmodel received in the event and used inMemberto update presence data.Client(enable_raw_presences=...)keyword argument.ClientStatus- Previously a private internal. The model representing Client Status data from discord.Member.client_status- Previously a private internal.Checklist