fix _sorting_bucket for ForumChannel
#10000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocado
commented
Nov 6, 2024
| @@ -2490,7 +2490,7 @@ def type(self) -> Literal[ChannelType.forum, ChannelType.media]: | |||
|
|
|||
| @property | |||
| def _sorting_bucket(self) -> int: | |||
| return ChannelType.text.value | |||
| return ChannelType.media.value if self._type == 16 else ChannelType.forum.value | |||
There was a problem hiding this comment.
Please let me know if I should just return self._type here or this change is fine.
|
I don't think this PR is correct. The sort bucket is where channel can be sorted relative to other channels (e.g. voice channels can be sorted between other voice channels). Text, forums, and media channels are all sorted in the same group so this PR isn't right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
ForumChannel._sorting_bucketmethod to return the correct value.Checklist