Fix Stats screen at max volume #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened this as a PR mainly because I don't fully understand why the this fixes the problem.. but it does fix it.
This was fixed in CSE.. see the issue there:
reference fellowship-of-the-roms/CrystalShireEngine#27
Furthermore, this is probably also related to Darsh' comment here: #857 (comment)
>I do think there's something wrong with the sound engine. A Pokemon's cry in the status screen isn't always going to have consistent volume (Voltorb is a good example of this). Not clear what's causing the issue.