MBU - touch up linux support and add to CI #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thearst3rd
commented
Aug 30, 2024
Comment on lines
+566
to
+569
| #- run: | ||
| # name: Upload to Artifact Storage | ||
| # command: | | ||
| # scp -o StrictHostKeyChecking=no -i $KEYPATH -P $PORT ~/MBHaxe/macos-dist/MBHaxe-Ultra-Mac.dmg $REMOTEDIR/MBHaxe-Ultra-Mac.dmg |
There was a problem hiding this comment.
Presumably this is some ssh server you are running locally? store_artifacts below worked for me. Might want to uncomment this block before merge to match the others
There was a problem hiding this comment.
Yeah please uncomment this.
|
Thanks for the PR, as for that specific error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows MBU to be built for linux, including compiling natively.
Unfortunately I realized there is currently an issue with multiplayer when running natively - If you a running the game natively and either join a server or somebody joins your server, the game crashes with this error:
When running marblegame.hl with hashlink, the issue does not occur. So not sure what is up with that. That should be fixed before this is officially distributed.
Will target MBG and MBP after this. MBU was surprisingly nice with only one case-sensitivity related issue. I know MBP will be much more of a pita