Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix validate_packet_checksum #20

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix validate_packet_checksum #20

merged 1 commit into from
Apr 3, 2024

Conversation

mattchrist
Copy link
Contributor

@mattchrist mattchrist commented Apr 3, 2024 •
edited
Loading

#15 introduced a subtle off-by-one indexing issue.

Fixes #19

Ralim
Ralim approved these changes Apr 3, 2024
View reviewed changes
Copy link
Owner

@Ralim Ralim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah heck, apologies for this.
Thank you for getting the PR raised before I even finished my workday and could look at this.

@Ralim Ralim enabled auto-merge (squash) April 3, 2024 04:17
@Ralim Ralim merged commit 6888f57 into Ralim:main Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralim Ralim Ralim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PineBuds BadChecksumErrors
2 participants
@mattchrist @Ralim