Refactor bestool to be more managable.
#12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shymega
force-pushed
the
refactor/shymega
branch
9 times, most recently
from
fe9dd04 to
27011eb
Compare
shymega
force-pushed
the
refactor/shymega
branch
8 times, most recently
from
f3c1ccd to
23d2592
Compare
shymega
force-pushed
the
refactor/shymega
branch
5 times, most recently
from
6d9a9bc to
cac6185
Compare
This is part of the refactor. Signed-off-by: Dom Rodriguez <[email protected]>
- Use Cargo 'workspaces', specify shared dependencies. - Move blobs to `src/beslib/src/blobs`, so that Nix can build in a sandbox. - Copy `supply-chain` directory to both `beslib` and `bestool`. TODO: Regenerate once refactor complete. Signed-off-by: Dom Rodriguez <[email protected]>
Signed-off-by: Dom Rodriguez <[email protected]>
Signed-off-by: Dom Rodriguez <[email protected]>
Signed-off-by: Dom Rodriguez <[email protected]>
Signed-off-by: Dom Rodriguez <[email protected]>
Signed-off-by: Dom Rodriguez <[email protected]>
Signed-off-by: Dom Rodriguez <[email protected]>
Signed-off-by: Dom Rodriguez <[email protected]>
Amateur mistake.
Discussed with @Ralim over Telegram, and initial feedback was to use `Write` trait, as for a transport-agnostic writer. However, I'm not sure how this will fit in with `serialport`.
shymega
force-pushed
the
refactor/shymega
branch
from
06b10f7 to
fca9dcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP branch. DRAFT only.