Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handling of freq_interp_kind flexible for future pyuvdata changes #442

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

bhazelton
Copy link
Member

Description

This fixes some things that break in a pending pyuvdata PR (RadioAstronomySoftwareGroup/pyuvdata#1378).

For now, this just makes sure we track freq_interp_kind on the BeamList object and either set it on the object or pass it to the interp functions depending on the version of pyuvdata (assessed by whether the attribute exists on UVBeam).

Long term, once we require a version of pyuvdata that doesn't have it as an attribute, I think we can entirely remove the uvb_params handling in telescope.py which will clean up that code substantially.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Reference simulation update or replacement
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

For all pull requests:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have checked that I reproduce the reference simulations or if there are differences they are explained below (if appropriate). If there are changes that are correct, I will update the reference simulation files after this PR is merged.
  • I have checked (e.g., using the benchmarking tools) that this change does not significantly increase typical runtimes. If it does, I have included a justification in the comments on this PR.
  • I have updated the CHANGELOG.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bc255a) 99.49% compared to head (b20be8b) 99.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   99.49%   99.50%           
=======================================
  Files          12       12           
  Lines        2199     2210   +11     
=======================================
+ Hits         2188     2199   +11     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @bhazelton!

@steven-murray steven-murray merged commit 3fcdb14 into main Jan 23, 2024
29 checks passed
@steven-murray steven-murray deleted the freq_interp_kind_changes branch January 23, 2024 11:22
bhazelton added a commit that referenced this pull request Feb 1, 2024
jpober pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants