Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monochrome icon android #549

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ThatOneCalculator
Copy link

@ThatOneCalculator ThatOneCalculator commented Jan 3, 2025

Before (on my device):

After (on emulator):
Screenshot 2025-01-02 at 6 03 30 PM

@richardo2016x
Copy link
Collaborator

richardo2016x commented Jan 3, 2025

Hi, thanks for your contribution! The changes surely make it more elegant on monochrome theme!

@ThatOneCalculator
Copy link
Author

@richardo2016x thank you! Anything preventing this from being reviewed/merged yet?

@ThatOneCalculator
Copy link
Author

Fixed the merge conflict. Would love if this could be reviewed and merged :)

@ThatOneCalculator
Copy link
Author

I also made a monochrome version with alpha portions to better show outlines, would you prefer I use that @richardo2016x ?

image

@richardo2016x
Copy link
Collaborator

@richardo2016x thank you! Anything preventing this from being reviewed/merged yet?

No, all things right! We will carry the changes into next our official version! Maybe in this week or next week.

@ThatOneCalculator
Copy link
Author

Perfect! If you would like, I can use the new version of the icon I posted above instead of the fully solid one – just let me know :)

@richardo2016x
Copy link
Collaborator

Perfect! If you would like, I can use the new version of the icon I posted above instead of the fully solid one – just let me know :)

Thanks! I will take one package to see which one is more suitable for us :)

@ThatOneCalculator
Copy link
Author

Sorry, not sure what you mean by that exactly... 😅

Do you mean like debug builds with both versions of the icon? If so, I'll upload the Android Vector Drawable version of the new icon.

@richardo2016x
Copy link
Collaborator

Sorry, not sure what you mean by that exactly... 😅

Do you mean like debug builds with both versions of the icon? If so, I'll upload the Android Vector Drawable version of the new icon.

I just mean I will build it and install it on my devices to See it in action 😄

I believe there's no any other things you need to do, after next version published, I will mention here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants