feat: Convert to Side Panel View #2498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passabilities
changed the title
|
@vvvvvv1vvvvvv is this something that could potentially get merged in? what are your thoughts? |
|
@vvvvvv1vvvvvv @heisenberg-2077 could you please have a look at this PR? It is a really nice feature |
CreeTar
suggested changes
Dec 12, 2024
| @@ -3,7 +3,7 @@ | |||
| .current-connection-block { | |||
| // position: absolute; | |||
| bottom: 24px; | |||
| width: 360px; | |||
| //width: 360px; | |||
There was a problem hiding this comment.
if leaving commented code, doesn't this required a TODO or explanation as to why?
|
|
||
| // Clean up the listener on component unmount | ||
| return () => { | ||
| chrome.runtime.onMessage.removeListener(handleTabUpdate); |
There was a problem hiding this comment.
isn't useEffect() called multiple times, and this means you are starting an interval call to getCurrentSite() every 5 seconds multiple times, because there is not clearInterval() in the returned method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Chrome extension feature to display as a side panel instead of the default popup.
There were quite a few places that had hard-coded height and width values. I tried my best to fix all the styles to make the view more dynamic but might have missed a few.
Closes #2159